[lld] r365478 - lld-link: Stop accepting /natvis and /fastfail in .drectve sections

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 06:30:03 PDT 2019


Author: nico
Date: Tue Jul  9 06:30:03 2019
New Revision: 365478

URL: http://llvm.org/viewvc/llvm-project?rev=365478&view=rev
Log:
lld-link: Stop accepting /natvis and /fastfail in .drectve sections

link.exe doesn't accept them either.

Differential Revision: https://reviews.llvm.org/D64352

Modified:
    lld/trunk/COFF/Driver.cpp

Modified: lld/trunk/COFF/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Driver.cpp?rev=365478&r1=365477&r2=365478&view=diff
==============================================================================
--- lld/trunk/COFF/Driver.cpp (original)
+++ lld/trunk/COFF/Driver.cpp Tue Jul  9 06:30:03 2019
@@ -365,10 +365,10 @@ void LinkerDriver::parseDirectives(Input
       parseSubsystem(Arg->getValue(), &Config->Subsystem,
                      &Config->MajorOSVersion, &Config->MinorOSVersion);
       break;
+    // Only add flags here that link.exe accepts in
+    // `#pragma comment(linker, "/flag")`-generated sections.
     case OPT_editandcontinue:
-    case OPT_fastfail:
     case OPT_guardsym:
-    case OPT_natvis:
     case OPT_throwingnew:
       break;
     default:




More information about the llvm-commits mailing list