[PATCH] D64197: [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable()

Tue Jul 9 05:18:06 PDT 2019

shchenz marked 2 inline comments as done.
shchenz added inline comments.

================
Comment at: llvm/lib/Analysis/TargetTransformInfo.cpp:157
+  BasicBlock *BB = L->getLoopPreheader();
+  bool UseLoopGuard = false;
+  if (!SE.isLoopEntryGuardedByCond(L, ICmpInst::ICMP_NE, ExitCount,
----------------
samparker wrote:
> Looks like this logic can be simplified now as UseLoopGuard is only ever equal to ForceGuardLoopEntry.
Good idea. Get your point. No matter 'test and set' form may fallback to the 'set' form or not, it will not impact that the Loop is a hardware loop. Updated accordingly.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64197/new/

https://reviews.llvm.org/D64197