[PATCH] D64291: [clangd] Rewrite of logic to rebuild the background index serving structures.

[Kadir Cetinkaya via Phabricator via llvm-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang-tools-extra/clangd/index/Background.cpp:186
+      if (NumActiveTasks == 1 && Queue.empty())
+      {
+        // We just finished the last item, the queue is going idle.
----------------
clang-format


================
Comment at: clang-tools-extra/clangd/index/Background.h:141
 
+  // The IndexRebuilder builds the serving data structures periodically in
+  // response to events in the background indexer. The goal is to ensure the
----------------
- do we really want to make 5 and 100 hardcoded in the comments?
- what about moving this class and its implementation to different header/source files?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64291/new/

https://reviews.llvm.org/D64291