[PATCH] D64361: [llvm-readelf] Print "File: lib.a(file.o)" info when dumping archive files.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks good aside from a couple of minor points.



================
Comment at: llvm/test/tools/llvm-readobj/archive.test:5
 # RUN: llvm-ar rc %t.a %p/Inputs/trivial.obj.elf-x86-64 %p/Inputs/trivial.obj.elf-i386 %p/Inputs/trivial.obj.coff-arm
-# RUN: llvm-readobj --all %t.a | FileCheck %s --check-prefixes=LLVM,COFF
-# RUN: llvm-readelf --all %t.a | FileCheck %s --check-prefixes=GNU,COFF
+# RUN: llvm-readobj --all %t.a | FileCheck %s --DARFILE="%t.a" --check-prefixes=HEADER,LLVM,COFF
+# RUN: llvm-readelf --all %t.a | FileCheck %s --DARFILE="%t.a" --check-prefixes=HEADER,GNU,COFF
----------------
Nit: I don't think it matters too much, but -D is a single-letter option, so would normally only have one dash before it.


================
Comment at: llvm/test/tools/llvm-readobj/archive.test:8
+
+# HEADER: File: [[ARFILE]](trivial.obj.elf-x86-64)
 
----------------
I think in this test particularly, you should check that there are the right number of new lines before and after "File: ..." using appropriate CHECK-NEXT/EMPTY markers.


================
Comment at: llvm/test/tools/llvm-readobj/thin-archive-paths.test:11
 # Show that relative paths in the file header printing look sensible.
-# RUN: llvm-readobj --file-headers a/relative.a | FileCheck %s --check-prefix=REL
-# REL: File: b/1.o
+# RUN: llvm-readobj --file-headers a/relative.a | FileCheck %s --DARFILE="a/relative.a" --check-prefix=REL
+# REL: File: [[ARFILE]](b/1.o)
----------------
nit --DARFILE -> -DARFILE


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64361/new/

https://reviews.llvm.org/D64361