[PATCH] D64297: [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 22:59:39 PDT 2019


MaskRay added inline comments.


================
Comment at: clang/lib/Tooling/JSONCompilationDatabase.cpp:272
+    bool HasCompiler =
+        (Args[1][0] != '-') && !llvm::sys::path::has_extension(Args[1]);
+    if (HasCompiler) {
----------------
If you do this, it may not work with `ccache gcc.exe`. If `ccache/gomacc/distcc` cannot be used as the compiler driver, just remove the check of `HasCompiler`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64297/new/

https://reviews.llvm.org/D64297





More information about the llvm-commits mailing list