[PATCH] D64361: [llvm-readelf] Print "File: lib.a(file.o)" info when dumping archive files.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 21:56:17 PDT 2019


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/tools/llvm-readobj/macho-universal-x86_64.i386.test:167
 MULTIHEADER-ARCHIVE: }
-MULTIHEADER-ARCHIVE: File: foo.o
+MULTIHEADER-ARCHIVE: File: [[ARFILE]](foo.o)
 MULTIHEADER-ARCHIVE: Format: Mach-O 32-bit i386
----------------
MaskRay wrote:
> Add a `MULTIHEADER-ARCHIVE-EMPTY:` and change this line to:
> `MULTIHEADER-ARCHIVE-NEXT: File: [[ARFILE]](foo.o)`
> to capture the newline issue.
For consistency other `File: ` should receive the same treatment..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64361/new/

https://reviews.llvm.org/D64361





More information about the llvm-commits mailing list