[PATCH] D64361: [llvm-readelf] Print "File: lib.a(file.o)" info when dumping archive files.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/macho-universal-x86_64.i386.test:151
 
-MULTIHEADER-ARCHIVE: File: hello.o
+MULTIHEADER-ARCHIVE: File: [[ARFILE]](hello.o)
 MULTIHEADER-ARCHIVE: Format: Mach-O 64-bit x86-64
----------------
There was one empty line between `}` and `File: `, now there are two, due to the ` Writer.startLine() << "\n";` change.


================
Comment at: llvm/tools/llvm-readobj/llvm-readobj.cpp:604
+    // Emit a trailing newline for each object's output.
+    Writer.startLine() << "\n";
   }
----------------
This will give us a trailing empty line. I think in a few other places, we do:

```
if (not first)
  print a new line
```

This pattern will not have a trailing empty line.

I think these probably don't matter but it'd be great if we can be consistent in the future..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64361/new/

https://reviews.llvm.org/D64361