[PATCH] D63703: [stack-safety] Refactoring StackSafetyAnalysis to be accsessible from other passes

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 17:12:51 PDT 2019


eugenis added inline comments.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:149
   // Informations about allocas uses.
-  SmallVector<AllocaInfo, 4> Allocas;
+  DenseMap<const AllocaInst*, AllocaInfo> Allocas;
   // Informations about parameters uses.
----------------
This could be very expensive - AllocaInfo is large, and DenseMap starts with 64 buckets. I wonder if SmallMapVector would work better here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63703/new/

https://reviews.llvm.org/D63703





More information about the llvm-commits mailing list