[PATCH] D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

> lgtm

Thanks!

>   5381 361257 out/clang/browser_tests.exe.rsp

Looking at that file, that looks like 10554 distinct args from the rsp file. That's ~80kB for the additional pointer, which for a link that's going to consume hundreds of MB isn't all that much overhead.

(If we did care about Arg size for some reason, there are a whole bunch of things we can do – e.g. removing CommaJoined and the OwnsValues member, or making the Option pointer in the arg and the unaliased arg not duplicate the OptTable pointer, etc.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64253/new/

https://reviews.llvm.org/D64253