[PATCH] D62927: [sanitizers][windows] Rtl-Heap Interception and tests

Mon Jul 8 13:54:38 PDT 2019

rnk added a comment.

In D62927#1574273 <https://reviews.llvm.org/D62927#1574273>, @jfb wrote:

> Reverted in https://reviews.llvm.org/rL365384
>
> because of: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/28842/steps/build%20stage%201/logs/stdio
>
>   /home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/projects/compiler-rt/lib/asan/asan_malloc_win.cc:23:2: error: #error "Missing arch or unsupported platform for Windows."
>    #error "Missing arch or unsupported platform for Windows."
>     ^~~~~
>   /home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/projects/compiler-rt/lib/asan/asan_malloc_win.cc:25:10: fatal error: heapapi.h: No such file or directory
>    #include <heapapi.h>
>             ^~~~~~~~~~~

This should be easy to fix, the entire asan_malloc_win.cc file should be encapsulated in the `#if SANITIZER_WINDOWS` block, including this.

I would recommend setting up a build and test environment on Linux to flush out these issues prior to committing in the future, since ASan is very platform sensitive. Once you get that working, feel free to reland when you get a chance.

Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62927/new/

https://reviews.llvm.org/D62927