[PATCH] D64355: [docs][Remarks] Add documentation for remarks in LLVM

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 11:27:59 PDT 2019


Meinersbur added a comment.

Thank your for working on the documentation!

Are you completing the FIXME's before committing?



================
Comment at: llvm/docs/Remarks.rst:97
+
+:doc:`llc <CommandGuide/llc>` and :doc:`opt <CommandGuide/opt>` support the
+following options:
----------------
Clang does as well using `-mllvm`


================
Comment at: llvm/docs/Remarks.rst:282
+    LLVMRemarkEntryRef Remark = NULL;
+    while ((Remark == LLVMRemarkParserGetNext(Parser))) {
+       // use Remark
----------------
Is this meant to use `=` (assignment instead of comparison)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64355/new/

https://reviews.llvm.org/D64355





More information about the llvm-commits mailing list