[PATCH] D64353: [AMDGPU] Run '' after isel to simplify PHIs.

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 10:11:14 PDT 2019


hliao added a comment.

In D64353#1573858 <https://reviews.llvm.org/D64353#1573858>, @arsenm wrote:

> I'm still confused. When I try your testcase, I see an earlier iterator crash in SILowerControlFlow


SILowerControlFlow runs after PHIElim, which converts PHI to COPY and could generate code like this in the last MBB

END_CF %v0, ....
%v0 = COPY %vX

the use (END_CF) is before the def (COPY).
the iterator in SILowereControlFlow starts from that def (COPY) to its use (END_CF). But, as they misplaced, it reaches the end of MBB first and triggers the assertion of illegal iterator access.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64353/new/

https://reviews.llvm.org/D64353





More information about the llvm-commits mailing list