[PATCH] D64326: Retire VS2015 Support

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 06:19:02 PDT 2019


aaron.ballman added a comment.

I think this patch should also update our user-facing documentation at the same time, such as https://clang.llvm.org/get_started.html, https://llvm.org/docs/GettingStarted.html, and https://llvm.org/docs/GettingStartedVS.html.



================
Comment at: cmake/modules/CheckCompilerVersion.cmake:13
 set(APPLECLANG_SOFT_ERROR 6.0)
-set(MSVC_MIN 19.00.24213.1)
+set(MSVC_MIN 19.1)
 set(MSVC_SOFT_ERROR 19.1)
----------------
I'd appreciate a comment listing more information about what version this is (thanks, Microsoft, for your terrible versioning scheme for this product). I know we didn't have such a comment before, but Visual Studio 2017 is also known as 1910, 14.10, and 15.0 simultaneously, and 19.1 is one of the lesser-known designations.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64326/new/

https://reviews.llvm.org/D64326





More information about the llvm-commits mailing list