[PATCH] D64246: [test/Object/nm-trivial-object.test] - Remove 5 precompiled binaries.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 04:16:05 PDT 2019


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: test/Object/nm-trivial-object.test:88
+# ELF64: 0000000000002004 D dataSym2
+# ELF64: 0000000000001000 T textSym1
+# ELF64: 0000000000001004 T textSym2
----------------
MaskRay wrote:
> What's the difference of `textSym1` and `textSym2`?
The intention was the same as for having `dataSym1` vs `dataSym2`: to show that different address is printed for symbols with different values.
That is what original `ELF-SEC-ADDR64` test case did I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64246/new/

https://reviews.llvm.org/D64246





More information about the llvm-commits mailing list