[PATCH] D64280: [lld][WebAssembly] Report undefined symbols during scanRelocations

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 04:07:05 PDT 2019


MaskRay added inline comments.


================
Comment at: lld/wasm/Relocations.cpp:36
+    return;
+  error(toString(Sym->getFile()) + ": undefined symbol: " + toString(*Sym));
+}
----------------
Not using early-return pattern may be cleaner here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64280/new/

https://reviews.llvm.org/D64280





More information about the llvm-commits mailing list