[PATCH] D64121: Rename variables so that they start with a lowercase letter.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 4 07:29:38 PDT 2019


MaskRay added a comment.

Generally looks good. +1 to Peter and James' suggestions: `is` -> `isec` and `prevISLimit` -> `prevIsecLimit`.

We have now an opportunity to rename global variables if they can be improved. I try to collect them below.

`config` (`Config.h`) `in` (`SyntheticSections.h`) `driver` (`Driver.h`) `sharedFiles` (`InputFiles.h`) `outputSections` (`OutputSections.h`) `partitions` (`InputSection.h`) `script` (`LinkerScript`) `symtab` (`SymbolTable.h`)

I am thinking `in` may be less ideal as a global variable name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64121/new/

https://reviews.llvm.org/D64121





More information about the llvm-commits mailing list