[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

[Hal Finkel via Phabricator via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/test/CodeGenOpenCL/as_type.cl:3
+// Once the attributor is on by default remove the following run line and change the prefixes below.
+// RUN: %clang_cc1 %s -emit-llvm -mllvm -attributor-disable=false -triple spir-unknown-unknown -o - | FileCheck %s --check-prefix=ATTRIBUTOR
 
----------------
I recommend leaving the Clang tests along. Clang tests that run the optimizer don't follow out best practices and, while end-to-end testing is valuable, I don't think that we should encourage general optimizer testing here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59919/new/

https://reviews.llvm.org/D59919