[PATCH] D63614: [System Model] [TTI] Update cache and prefetch TTI interfaces

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 09:57:18 PDT 2019


hfinkel added a comment.

In D63614#1571616 <https://reviews.llvm.org/D63614#1571616>, @greened wrote:

> I know this now says "ready to land" but is one review really sufficient?


This is a refactoring of existing functionality (and, FWIW, functionality originally contributed by me, later generalized by @anemet, and others). If you're looking for particular feedback from others, please call that out explicitly. The patch has been online for a couple of weeks, and there's been time for feedback. In short, yes, you should feel free to proceed.

Also, it is useful to note that all code is subject to post-commit code review, even for patches that have received pre-commit review. You may yet get feedback after you commit the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63614/new/

https://reviews.llvm.org/D63614





More information about the llvm-commits mailing list