[PATCH] D64231: [FileCheck] Simplify numeric variable interface

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 07:35:14 PDT 2019


thopre added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:28
+void FileCheckNumericVariable::setValue(uint64_t NewValue) {
+  assert(!Value && "Overwriting numeric variable's value");
   Value = NewValue;
----------------
jhenderson wrote:
> jhenderson wrote:
> > perhaps add "is not allowed".
> This hasn't been addressed?
Oops, dunno how I missed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64231/new/

https://reviews.llvm.org/D64231





More information about the llvm-commits mailing list