[PATCH] D64206: [llvm\test\Object] - An initial step to cleanup the test cases.

Fri Jul 5 07:03:11 PDT 2019

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM if @jhenderson's comments are addressed.

================
Comment at: test/Object/X86/objdump-trivial-object.test:61
+# ELF-x86-64:        0:       48 83 ec 08             subq    $8, %rsp
+# ELF-x86-64:        4:       c7 44 24 04 00 00 00 00 movl    $0, 4(%rsp)
+# ELF-x86-64:        c:       bf 00 00 00 00          movl    $0, %edi
----------------
grimar wrote:
> MaskRay wrote:
> > MaskRay wrote:
> > > `       4: c7 44 24 04 00 00 00 00       movl    $0, 4(%rsp)`
> > > `00       movl`
> > 
> > Since you are updating this test, it may be good to make the number of spaces consistent with the actual output.
> > 
> > 
> Ok. I was not sure this makes much sence until `-strict-whitespace` is used for `FileCheck` invocations actually,
> but I have no strong objections if you feel this is better.
I just wondered why you changed the number of spaces but didn't make it look like the actual output..

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64206/new/

https://reviews.llvm.org/D64206