[PATCH] D64206: [llvm\test\Object] - An initial step to cleanup the test cases.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 06:50:21 PDT 2019


grimar added inline comments.


================
Comment at: test/Object/X86/objdump-trivial-object.test:61
+# ELF-x86-64:        0:       48 83 ec 08             subq    $8, %rsp
+# ELF-x86-64:        4:       c7 44 24 04 00 00 00 00 movl    $0, 4(%rsp)
+# ELF-x86-64:        c:       bf 00 00 00 00          movl    $0, %edi
----------------
MaskRay wrote:
> MaskRay wrote:
> > `       4: c7 44 24 04 00 00 00 00       movl    $0, 4(%rsp)`
> > `00       movl`
> 
> Since you are updating this test, it may be good to make the number of spaces consistent with the actual output.
> 
> 
Ok. I was not sure this makes much sence until `-strict-whitespace` is used for `FileCheck` invocations actually,
but I have no strong objections if you feel this is better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64206/new/

https://reviews.llvm.org/D64206





More information about the llvm-commits mailing list