[PATCH] D64231: [FileCheck] Simplify numeric variable interface

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 05:43:06 PDT 2019


jhenderson added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:28
+void FileCheckNumericVariable::setValue(uint64_t NewValue) {
+  assert(!Value && "Overwriting numeric variable's value");
   Value = NewValue;
----------------
jhenderson wrote:
> perhaps add "is not allowed".
This hasn't been addressed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64231/new/

https://reviews.llvm.org/D64231





More information about the llvm-commits mailing list