[PATCH] D64240: [LIT] emit timeout error message only if timeout was reached

[Alexey Sachkov via Phabricator via llvm-commits]

AlexeySachkov created this revision.
AlexeySachkov added reviewers: ddunbar, mgorny, modocache.
Herald added a subscriber: delcypher.
Herald added a project: LLVM.

This improves readability of LIT output: previously
error messages gets emitted that say that there was no error:

error: command reached timeout: False


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D64240

Files:
  llvm/utils/lit/lit/TestRunner.py


Index: llvm/utils/lit/lit/TestRunner.py
===================================================================
--- llvm/utils/lit/lit/TestRunner.py
+++ llvm/utils/lit/lit/TestRunner.py
@@ -1118,7 +1118,7 @@
                 codeStr = str(result.exitCode)
             out += "error: command failed with exit status: %s\n" % (
                 codeStr,)
-        if litConfig.maxIndividualTestTime > 0:
+        if litConfig.maxIndividualTestTime > 0 and result.timeoutReached:
             out += 'error: command reached timeout: %s\n' % (
                 str(result.timeoutReached),)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64240.208136.patch
Type: text/x-patch
Size: 585 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190705/e5a0bc39/attachment.bin>