[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 01:07:45 PDT 2019


MaskRay added inline comments.


================
Comment at: lib/Target/RISCV/RISCVFrameLowering.cpp:394
+
+  using std::max;
+  unsigned MaxReg = 0;
----------------
Delete `using std::max;`




================
Comment at: lib/Target/RISCV/RISCVFrameLowering.cpp:399
+
+  switch (MaxReg) {
+  default:
----------------
`switch (*std::max_element(CSI.begin(), CSI.end())) {`


================
Comment at: lib/Target/RISCV/RISCVFrameLowering.cpp:428
+
+  using std::max;
+  unsigned MaxReg = 0;
----------------
Delete this


================
Comment at: lib/Target/RISCV/RISCVFrameLowering.cpp:433
+
+  switch (MaxReg) {
+  default:
----------------
`switch (*std::max_element(CSI.begin(), CSI.end())) {`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62686/new/

https://reviews.llvm.org/D62686





More information about the llvm-commits mailing list