[PATCH] D63935: [llvm-ar][test] Increase llvm-ar test coverage

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 4 19:48:24 PDT 2019


MaskRay added inline comments.


================
Comment at: test/tools/llvm-ar/dash-before-letter.test:1
+# Test the use of dash before key letters.
+
----------------
gbreynoo wrote:
> MaskRay wrote:
> > Can you merge this test with default-add.test ?
> I didn't realise that default-add.test already covered this functionality. Unless we want to spin off a new test explicitly for dashes before letters then I think default-add.test should suffice for coverage.
The spin-off `dash-before-letter.test` may be clearer. You can probably delete the multi-dash tests from `default-add.test`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63935/new/

https://reviews.llvm.org/D63935





More information about the llvm-commits mailing list