[PATCH] D60387: FileCheck [7/12]: Arbitrary long numeric expressions

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:553
+  /// class representing that operand in the AST of the expression or an error
+  /// holding a diagnostic against \p SM otherwise.
+  Expected<std::shared_ptr<FileCheckExpressionAST>>
----------------
jhenderson wrote:
> "against \p SM"? I'm not sure I understand this change in terminology.
I've used it in other place already. I'm using "against" because the diagnostic relates to the buffer held by SM (it is created via SM.GetMessage)


================
Comment at: llvm/lib/Support/FileCheck.cpp:198
+  uint64_t LiteralValue;
+  if (!Expr.consumeInteger(10 /*Radix*/, LiteralValue))
+    return std::make_shared<FileCheckExpressionLiteral>(LiteralValue);
----------------
jhenderson wrote:
> I'm guessing there is a plan to allow other Radixes too? It seems like it would be normal to want to use hex, for example.
/There is yes. See patch 9/12


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60387/new/

https://reviews.llvm.org/D60387