[PATCH] D64144: [AMDGPU] Update NumUserSGPRs and NumSystemSGPRs in MIR parsing.

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 4 11:30:51 PDT 2019


hliao added a comment.

In D64144#1569828 <https://reviews.llvm.org/D64144#1569828>, @arsenm wrote:

> Test? I’m also note sure we get much value by tracking these here. I don’t think they are accurate for shaders


There are several places behaving slightly differently by checking `getNumPreloadedSGPRs`, which is the sum of NumUserSGPRs and NumSystemSGRPs. The test in https://reviews.llvm.org/D64145 relies on that to avoid assigning a preloaded register again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64144/new/

https://reviews.llvm.org/D64144





More information about the llvm-commits mailing list