[PATCH] D64136: [ELF] resolveUndefined: ignore undefined symbols in SharedFile for Undefined and SharedSymbol

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

LG, I have no other comments except a minor suggestion below.



================
Comment at: ELF/Symbols.cpp:481
            toString(Other.File) + " refers to " + toString(File));
+  } else {
+    // Undefined symbols in a SharedFile do not change the binding.
----------------
Perhaps an early return would look a bit better here:


```
if (isLazy()) {
...
return;
}

// Undefined symbols in a SharedFile do not change the binding.
if (isa_and_nonnull<SharedFile>(Other.File))
  return;

...
```


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64136/new/

https://reviews.llvm.org/D64136