[PATCH] D64121: Rename variables so that they start with a lowercase letter.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 17:56:50 PDT 2019


ruiu marked 2 inline comments as done.
ruiu added a comment.

This patch is still machine-generated with an updated version of https://reviews.llvm.org/D64123. There's no manual post-processing.



================
Comment at: lld/ELF/Arch/MipsArchTree.cpp:77
 
-    uint32_t ABI2 = F.Flags & (EF_MIPS_ABI | EF_MIPS_ABI2);
-    if (ABI != ABI2)
-      error(toString(F.File) + ": ABI '" + getAbiName(ABI2) +
-            "' is incompatible with target ABI '" + getAbiName(ABI) + "'");
+    uint32_t ABI2 = f.flags & (EF_MIPS_ABI | EF_MIPS_ABI2);
+    if (abi != ABI2)
----------------
peter.smith wrote:
> Looks like this got missed by the rename. I've not found any others yet.
Fixed


================
Comment at: lld/ELF/MapFile.cpp:90
+    raw_string_ostream os(str[i]);
+    OutputSection *oSec = syms[i]->getOutputSection();
+    uint64_t vma = syms[i]->getVA();
----------------
peter.smith wrote:
> maybe worth a special case for OSec -> osec to match other uses of isec.
Done


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64121/new/

https://reviews.llvm.org/D64121





More information about the llvm-commits mailing list