[PATCH] D64060: [LoopInfo] Extend getExitEdges API

[Serguei Katkov via Phabricator via llvm-commits]

skatkov marked an inline comment as done.
skatkov added inline comments.


================
Comment at: include/llvm/Analysis/LoopInfo.h:282
+  template <class ParamBlockT>
+  void getExitEdges(SmallVectorImpl<std::pair<ParamBlockT *, ParamBlockT *> > &
+                        ExitEdges) const {
----------------
fhahn wrote:
> Is there a reason why the implementation was moved to here? Could it stay in LoopInfoImpl.h?
Yes, there is a reason. To support both const and non-const ParamBlockT in SmallVector argument I introduced the new template parameter ParamBockT. As a result if I keep the implementation in LoopInfoImpl.h I have a compilation error due to users includes this header. So the movement to this header is required.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64060/new/

https://reviews.llvm.org/D64060