[PATCH] D64170: [llvm-objcopy][NFC] Refactor output target parsing v2

[Seiya Nuta via Phabricator via llvm-commits]

seiya created this revision.
Herald added subscribers: llvm-commits, MaskRay, jakehehrlich, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: alexshap.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.

Use an enum instead of string to hold the output file format in Config.InputFormat and Config.OutputFormat. It's essential to support other output file formats other than ELF.

This patch originally has been submitted as D63239 <https://reviews.llvm.org/D63239> and I've committed to the repository. However, it has an use-of-uninitialized-value bug and reverted in r364379.

This patch includes the fix for the bug by setting Config.InputFormat/Config.OutputFormat in parseStripOptions.


https://reviews.llvm.org/D64170

Files:
  llvm/tools/llvm-objcopy/CopyConfig.cpp
  llvm/tools/llvm-objcopy/CopyConfig.h
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64170.207917.patch
Type: text/x-patch
Size: 8771 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190703/dfc3cd40/attachment.bin>