[PATCH] D64102: [llvm-lipo] Implement -create part 1

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap accepted this revision.
alexshap added a comment.
This revision is now accepted and ready to land.

I've added a couple of minor comments, but other than that - looks good to me) I'd wait for @mtrent 's approval as well



================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:255
+static std::string getArchString(const MachOObjectFile &ObjectFile) {
+  Triple T = ObjectFile.getArchTriple();
+  const StringRef ObjectArch = T.getArchName();
----------------
const Triple


================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:271
   if (auto UO = dyn_cast<MachOUniversalBinary>(InputBinary)) {
-    for (MachOUniversalBinary::object_iterator I = UO->begin_objects(),
-                                               E = UO->end_objects();
-         I != E; ++I) {
+    for (auto O : UO->objects()) {
       Expected<std::unique_ptr<MachOObjectFile>> BinaryOrError =
----------------
for (const auto &O : ... )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64102/new/

https://reviews.llvm.org/D64102