[PATCH] D63850: [AMDGPU] Kernel arg metadata: added support for "__hip_texture" type.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 14:27:56 PDT 2019


arsenm added inline comments.


================
Comment at: llvm/trunk/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:107-109
+  if (isa<PointerType>(Ty) && Ty->getPointerElementType()->isStructTy() &&
+      Ty->getPointerElementType()->getStructName() == "struct.__hip_texture") {
+    return ValueKind::Image;
----------------
You cannot rely on the pointer element type, or the name of IR types


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63850/new/

https://reviews.llvm.org/D63850





More information about the llvm-commits mailing list