[PATCH] D64121: Rename variables so that they start with a lowercase letter.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 01:20:56 PDT 2019


ruiu added a comment.

In D64121#1567869 <https://reviews.llvm.org/D64121#1567869>, @MaskRay wrote:

> FWIW my feeling regarding https://lists.llvm.org/pipermail/llvm-dev/2019-February/130083.html is that `variable_name` (used by lldb) is better than `variableName`. Though both are better than `VariableName`, the former makes it stand out from `functionName`...


I didn't intend to upload this patch to share, I just wanted to test how it would look like on Phabricator, but anyways. I don't have a strong preference over underscore or camelCase. I rename variables so that they are in camelCase because that's a minimal change -- for most variables, that results in a single letter change. It seems it is easier to get a consensus with this approach than adopting underscore naming style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64121/new/

https://reviews.llvm.org/D64121





More information about the llvm-commits mailing list