[PATCH] D64152: [Attributor] Deduce "align" attribute on return value
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 3 12:56:39 PDT 2019
jdoerfert added a comment.
In D64152#1569030 <https://reviews.llvm.org/D64152#1569030>, @uenoku wrote:
> @jdoerfert
> I know align attribute is integer attribute and we need somewhat different deduction with other attributes. However, I implement `AAAlignImpl` as a subclass of BooleanState for now. Is it better to add some base class for the integer attribute?
Why not make it derive from `IntegerState` and use the integer as the alignment, zero would be the worst possible = unknown.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64152/new/
https://reviews.llvm.org/D64152
More information about the llvm-commits
mailing list