[PATCH] D61289: [globalisel] Add G_SEXT_INREG

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 12:28:09 PDT 2019


arsenm added inline comments.


================
Comment at: llvm/unittests/CodeGen/GlobalISel/PatternMatchTest.cpp:276
+  EXPECT_TRUE(match);
+  EXPECT_EQ(Cst, 1);
+
----------------
It's a gtestism that these should be swapped to get the correct expected/actual error message


================
Comment at: llvm/unittests/CodeGen/GlobalISel/PatternMatchTest.cpp:284
+  EXPECT_TRUE(match);
+  EXPECT_EQ(Cst, -0x80);
 }
----------------
Ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61289/new/

https://reviews.llvm.org/D61289





More information about the llvm-commits mailing list