[PATCH] D63972: [PowerPC] Do the Early Return for the li and unconditional branch

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 11:46:33 PDT 2019


efriedma added a comment.

> The line 29 b .LBB0_10 is created after running the pass branch-folder,

I did a quick test with -print-after-all, and it looks like it's actually created by MachineBlockPlacement?

If we're going to do this transform, we should use the existing TailDup code to do it, not reimplement it in PPCEarlyReturn.  Would it make sense to run a re-run the entire tail duplication pass after block placement?  Or should we try to do something more targeted?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63972/new/

https://reviews.llvm.org/D63972





More information about the llvm-commits mailing list