[PATCH] D64141: [CodeGen] Add larger vector types for i32 and f32

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 11:26:38 PDT 2019


jmolloy added a comment.

Most of this looks mechanical; I don't think the MVT changes should be contentious. However, the "is65536BitVector()" predicates are starting to get a bit unwieldy to read.

Does an out of tree target need these predicates? I feel they're sufficiently unreadable to either change the format ("is64kBitVector"?) or elide them for larger types.

Cheers,

James



================
Comment at: llvm/lib/CodeGen/ValueTypes.cpp:111
+bool EVT::isExtended65536BitVector() const {
+  return isExtendedVector() && getExtendedSizeInBits() ==65536;
+}
----------------
[Formatting] Space missing here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64141/new/

https://reviews.llvm.org/D64141





More information about the llvm-commits mailing list