[PATCH] D64136: [ELF] resolveUndefined: ignore undefined symbols in SharedFile

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 08:34:12 PDT 2019


peter.smith added inline comments.


================
Comment at: ELF/Symbols.cpp:413
 
+  // Ignore undefined symbols in a SharedFile.
+  if (isa_and_nonnull<SharedFile>(Other.File))
----------------
Wouldn't this prevent a non-weak reference from a shared library from fetching an archive member? Or am I missing something else that permits that. Apologies I've not got much time left today.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64136/new/

https://reviews.llvm.org/D64136





More information about the llvm-commits mailing list