[PATCH] D64014: [Object/ELF.h] - Improve error reporting.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: include/llvm/Object/ELF.h:59
+    return "[index " + std::to_string(Sec - &TableOrErr->front()) + "]";
+  // To make this helper be more convenient for the error reporting purposes we
+  // drop the error. But anyways actually it should never be triggered. Up to
----------------
"for error"


================
Comment at: include/llvm/Object/ELF.h:60
+  // To make this helper be more convenient for the error reporting purposes we
+  // drop the error. But anyways actually it should never be triggered. Up to
+  // this place, our code should already have called 'sections()' earlier and
----------------
anyways actually -> really
Up to this place -> Before this point


================
Comment at: include/llvm/Object/ELF.h:61
+  // drop the error. But anyways actually it should never be triggered. Up to
+  // this place, our code should already have called 'sections()' earlier and
+  // report a proper error on failure.
----------------
should already have called 'sections()' earlier -> should have called 'sections()'


================
Comment at: include/llvm/Object/ELF.h:62
+  // this place, our code should already have called 'sections()' earlier and
+  // report a proper error on failure.
+  llvm::consumeError(TableOrErr.takeError());
----------------
report -> reported


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64014/new/

https://reviews.llvm.org/D64014