[PATCH] D63877: Avoid infinite loop with asan interception

[serge via Phabricator via llvm-commits]

serge-sans-paille marked 2 inline comments as done.
serge-sans-paille added inline comments.


================
Comment at: compiler-rt/test/asan/TestCases/dlopen-mixed-c-cxx.c:2
+// RUN: %clangxx_asan -xc++ -shared -fPIC -o %t.so - < %s
+// RUN: %clang_asan -fsanitize=address %s -o %t.out -ldl
+// RUN: ASAN_OPTIONS=verbosity=1 not %t.out %t.so 2>&1 | FileCheck %s
----------------
vitalybuka wrote:
> kcc wrote:
> > Do you need -fsanitize=address here? 
> It's marked as done, but I don't see a difference
Both the shared library and the main executable are now compiled with `-fsanitize=address`, is there something else missing?


================
Comment at: compiler-rt/test/asan/TestCases/dlopen-mixed-c-cxx.c:33
+  int (*bar)(void);
+  void *handle = dlopen(argv[1], RTLD_LAZY);
+  assert(handle);
----------------
vitalybuka wrote:
> Test uses dlopen, so it should go into Linux, or Posix
I've put it into the Linux/ directory, if that's not what expected (like, a special REQUIRES is needed), please advise!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63877/new/

https://reviews.llvm.org/D63877