[PATCH] D63521: Teach the symbolizer lib symbolize objects directly.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with a couple of nits. Happy with or without them.



================
Comment at: llvm/lib/DebugInfo/Symbolize/Symbolize.cpp:88
+    return InfoOrErr.takeError();
+  return symbolizeCodeCommon(InfoOrErr.get(), ModuleOffset);
+}
----------------
It's more common to use `*InfoOrErr` for Expected, I believe, to get the actual value.


================
Comment at: llvm/lib/DebugInfo/Symbolize/Symbolize.cpp:97
+    return InfoOrErr.takeError();
+  return symbolizeCodeCommon(InfoOrErr.get(), ModuleOffset);
+}
----------------
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63521/new/

https://reviews.llvm.org/D63521