[PATCH] D64023: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.6

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 17:59:31 PDT 2019


yln added a comment.

In D64023#1566002 <https://reviews.llvm.org/D64023#1566002>, @dvyukov wrote:

> Rubber stamp LGTM, if you want a real review please ask somebody else. But if you are sure it's good and covered by tests, submit.


I have learnt that one can never be 100% sure ;)

We have the following tests that cover this (`--filter jmp`):

  PASS: ThreadSanitizer-arm64e-ios :: fiber_longjmp.cc (1 of 6)
  PASS: ThreadSanitizer-arm64e-ios :: longjmp.cc (2 of 6)
  PASS: ThreadSanitizer-arm64e-ios :: longjmp2.cc (3 of 6)
  PASS: ThreadSanitizer-arm64e-ios :: longjmp3.cc (4 of 6)
  PASS: ThreadSanitizer-arm64e-ios :: longjmp4.cc (5 of 6)
  PASS: ThreadSanitizer-arm64e-ios :: signal_longjmp.cc (6 of 6)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64023/new/

https://reviews.llvm.org/D64023





More information about the llvm-commits mailing list