[PATCH] D63466: [Remarks] Add an LLVM-bitstream-based remark serializer

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 17:58:41 PDT 2019


thegameg updated this revision to Diff 207681.
thegameg added a comment.

This adds a lot more testing.

1. BitstreamRemarksFormatTest.cpp: test for the stability of the versions and IDs.
2. BitstreamRemarksSerializerTest.cpp: don't depend on actual codegen to generate remarks. Manually create remark objects that get serialized then analyzed by the bitcode analyzer. This tests the multiple remark container types for the metadata blocks.
3. Gets rid of the codegen test: llvm/test/CodeGen/X86/remarks-bitstream.ll.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63466/new/

https://reviews.llvm.org/D63466

Files:
  llvm/include/llvm/IR/RemarkStreamer.h
  llvm/include/llvm/Remarks/BitstreamRemarkContainer.h
  llvm/include/llvm/Remarks/BitstreamRemarkSerializer.h
  llvm/include/llvm/Remarks/Remark.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/IR/RemarkStreamer.cpp
  llvm/lib/Remarks/BitstreamRemarkSerializer.cpp
  llvm/lib/Remarks/CMakeLists.txt
  llvm/lib/Remarks/RemarkStringTable.cpp
  llvm/test/Bitcode/stream-types.c
  llvm/unittests/Remarks/BitstreamRemarksFormatTest.cpp
  llvm/unittests/Remarks/BitstreamRemarksSerializerTest.cpp
  llvm/unittests/Remarks/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63466.207681.patch
Type: text/x-patch
Size: 40051 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190703/f863be43/attachment.bin>


More information about the llvm-commits mailing list