[PATCH] D64045: [InstrProfiling] Put instrumentation into comdat group with function

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/lib/ProfileData/InstrProf.cpp:1055
+
+  // available_externally functions have their body elsewhere so ignore those.
+  if (F.getLinkage() == GlobalValue::AvailableExternallyLinkage)
----------------
davidxl wrote:
> See the comments in the code deleted by this patch. 
> 
> Here you reverse the logic. IIRC, it will greatly increase the size of the profile data as the counter and per function data for externally available symbols won't be commoned.
I've reverted that part of the change and checked on an example that those symbols are now being commoned.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64045/new/

https://reviews.llvm.org/D64045