[PATCH] D64102: [llvm-lipo] Implement -create part 1

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:404
+template <class FatArchType>
+static SmallVector<FatArchType, 2> buildFatArchList(ArrayRef<Slice> Slices) {
+  SmallVector<FatArchType, 2> FatArchList;
----------------
compnerd wrote:
> I think that it is better to return a `SmallVectorImpl<FatArchType>`
i think no, this would cause "slicing", SmallVector has 2 immediate bases (nonempty) https://llvm.org/doxygen/SmallVector_8h_source.html#837


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64102/new/

https://reviews.llvm.org/D64102