[PATCH] D63662: Changing CodeView Debug info Type record output

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeViewRecordIO.h:49
 public:
-  explicit CodeViewRecordIO(BinaryStreamReader &Reader) : Reader(&Reader) {}
-  explicit CodeViewRecordIO(BinaryStreamWriter &Writer) : Writer(&Writer) {}
+  explicit CodeViewRecordIO(BinaryStreamReader &Reader) : Reader(&Reader) {} // deserializes records to structures
+  explicit CodeViewRecordIO(BinaryStreamWriter &Writer) : Writer(&Writer) {} // serializes records to buffer
----------------
This runs over the 80 character limit, I would recommend writing it on the previous line, here and in one other place.


================
Comment at: llvm/lib/DebugInfo/CodeView/CodeViewRecordIO.cpp:39
+
+  if (isStreaming()) { // For streaming mode, add padding to align with 4byte boundaries for each record
+    uint32_t Align = getStreamedLen() % 4;
----------------
Needs wrapping


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63662/new/

https://reviews.llvm.org/D63662