[PATCH] D61289: [globalisel] Add G_SEXT_INREG

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 13:33:38 PDT 2019


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

In D61289#1563253 <https://reviews.llvm.org/D61289#1563253>, @arsenm wrote:

> I think it would be useful to have generic UBFE/SBFE instructions, which could take the place of sext_inreg. However, those would allow variable offset/width, so it wouldn't bee quite the same.


Not sure what the benefit would be there. IIRC we don't really have a need for zext_in_reg and the legalizer isn't going to produce variable shifts in most cases.

I think this has been reviewed enough now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61289/new/

https://reviews.llvm.org/D61289





More information about the llvm-commits mailing list