[PATCH] D63503: cmake: Add CLANG_LINK_CLANG_DYLIB option

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

One comment inline. Otherwise LGTM.



================
Comment at: clang/CMakeLists.txt:327
+set(CLANG_LINK_CLANG_DYLIB ${LLVM_LINK_LLVM_DYLIB} CACHE BOOL
+    "Link tools against libclang_shared.so")
+
----------------
We should generate a config error if `LLVM_LINK_LLVM_DYLIB=Off` and `CLANG_LINK_CLANG_DYLIB=On`, because that will cause some odd errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63503/new/

https://reviews.llvm.org/D63503