[PATCH] D64077: [ELF] Assert sizeof(SymbolUnion) <= 80

[Fangrui Song via Phabricator via llvm-commits]

MaskRay updated this revision to Diff 207558.
MaskRay added a comment.

Add the comment suggested by peter.smith


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64077/new/

https://reviews.llvm.org/D64077

Files:
  ELF/Symbols.h


Index: ELF/Symbols.h
===================================================================
--- ELF/Symbols.h
+++ ELF/Symbols.h
@@ -460,6 +460,11 @@
   alignas(LazyObject) char F[sizeof(LazyObject)];
 };
 
+// It is important to keep the size of SymbolUnion small for performance and
+// memory usage reasons. 80 bytes is a soft limit based on the size of Defined
+// on a 64-bit system.
+static_assert(sizeof(SymbolUnion) <= 80, "SymbolUnion too large");
+
 template <typename T> struct AssertSymbol {
   static_assert(std::is_trivially_destructible<T>(),
                 "Symbol types must be trivially destructible");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64077.207558.patch
Type: text/x-patch
Size: 619 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190702/58f32675/attachment.bin>